[RFC] Standardize Collective (AllGatherOp, AllReduceOp, AllToAllOp) ops to support variadic operand/result #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhigunj
changed the title
mlevesquedion
approved these changes
Mar 18, 2024
abhigunj
force-pushed
the
rfc_collectives
branch
from
09231aa
to
db881b5
Compare
ghpvnist
requested changes
Mar 21, 2024
sdasgup3
approved these changes
Apr 29, 2024
cantonios
reviewed
May 16, 2024
GleasonK
approved these changes
Jun 25, 2024
ghpvnist
approved these changes
Jun 26, 2024
abhigunj
added a commit
that referenced
this pull request
Jul 22, 2024
The PR allows each Process from the ProcessGrid to contribute more than one tensor at `ProcessGrid::rendezvous`. This is the first set of change, will be followed by interpreter updates to collectives. Note: The PR does **not** make collectives interpreter variadic. Tested: 1. No existing test failures indicate no change in behavior for ops using the `rendezvous` 2. The diff is tested with new variadic interpreter for `all_reduce` op. Will upload the PR soon. ref: #2099
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This RFC proposes standardizing collective (AllGatherOp, AllReduceOp, AllToAllOp) ops to enable support for
multi-operandandmulti-resultPlease review and provide you feedback.