Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional handlers for publisher errors, access denied, and audio level change #28

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sedenardi
Copy link

Right now the only error messages you get are if the test setup itself fails; all errors from the OT.Publisher are left unhandled (and just dump to the console). This PR allows the client to handle these errors to give a more accurate sense of the problem (such as whether the hardware isn't there, whether the browser is blocking it, whether the mic is muted, etc.).

I've also modified the references to window so that this can be used in node.js and webpack environments where the window variable isn't declared.

I've updated the tests and the docs accordingly. Let me know if you have any questions, comments, or concerns.

@mheap mheap changed the base branch from master to main March 22, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant