Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install ARO with custom disk encryption set #56953

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mgahagan73
Copy link
Contributor

Add a workflow where we create an azure disk encryption set, then install ARO configured to use the DES for control plane and worker nodes.

Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgahagan73
Once this PR has been reviewed and has the lgtm label, please assign jianlinliu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mgahagan73: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-qe-ocp-qe-perfscale-ci-main-aro-4.13-nightly-x86-upi-node-density-cni-6nodes openshift-qe/ocp-qe-perfscale-ci presubmit Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.15-installer-rehearse-azure-aro N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-aro-4.14-aro-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-aro-4.13-aro-f28 N/A periodic Registry content changed
periodic-ci-redhat-chaos-prow-scripts-main-4.16-nightly-krkn-hub-tests-aro-416 N/A periodic Registry content changed
periodic-ci-quay-quay-tests-master-quay-aro-ocp-quay-e2e-tests-quay311-aro-ocp417 N/A periodic Registry content changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aro-4.13-nightly-x86-upi-node-density-heavy-6nodes N/A periodic Registry content changed
periodic-ci-quay-quay-tests-master-quay-aro-ocp-quay-e2e-tests-quay310-aro-ocp417 N/A periodic Registry content changed
periodic-ci-openshift-qe-ocp-qe-perfscale-ci-main-aro-4.13-nightly-x86-upi-control-plane-6nodes N/A periodic Registry content changed
periodic-ci-redhat-chaos-prow-scripts-main-4.15-nightly-krkn-hub-tests-aro-415 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.13-installer-rehearse-azure-aro N/A periodic Registry content changed
periodic-ci-quay-quay-tests-master-quay-aro-ocp-quay-e2e-tests-quay312-aro-ocp417 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-aro-4.12-aro-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-amd64-nightly-4.14-upgrade-from-aro-4.14-aro-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-aro-byok N/A periodic Periodic changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-4.15-upgrade-from-aro-4.14-aro-f28 N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mgahagan73
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.14-installer-rehearse-aro-byok

@openshift-ci-robot
Copy link
Contributor

@mgahagan73: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

@mgahagan73: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/generated-config 99c3bb5 link true /test generated-config

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

1 similar comment
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -61,6 +61,13 @@ tests:
env:
BASE_DOMAIN: qe.azure.devcluster.openshift.com
workflow: cucushift-installer-rehearse-azure-ipi-private
- as: installer-rehearse-aro-byok
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- as: installer-rehearse-aro-byok
- as: installer-rehearse-aro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants