-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mirror-images-qe-test-images re-usable outside QE env #56937
base: master
Are you sure you want to change the base?
Conversation
/pj-rehearse ack |
@EmilienM: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@EmilienM,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
* Skip the step if ${SHARED_DIR}/mirror_registry_url doesn't exist. It allows to run that step in shared workflows and the step is skipped when a mirror is not used by the job. * Allow to provide a pre-created list of images to mirror. This can be triggered by `QE_IMAGES` set to false (default is true for backward compatibility). This allows us to generate the list in a previous step and give the file here so the mirror can be populated. We are not interested by QE images but by the script to push the images into the mirror. * Load proxy env for disconnected clusters and mirrors.
[REHEARSALNOTIFIER]
A total of 66 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@EmilienM: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: EmilienM, MaysaMacedo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It allows to run that step in shared workflows and the step is skipped
when a mirror is not used by the job.
triggered by
QE_IMAGES
set to false (default is true for backwardcompatibility). This allows us to generate the list in a previous step
and give the file here so the mirror can be populated.
We are not interested by QE images but by the script to push the
images into the mirror.