NO-JIRA: reduce node lease back off flames to 2 #29110
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kannon92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -71,8 +71,7 @@ func nodeFailedLeaseErrors(startedAt time.Time, finalIntervals monitorapi.Interv | |||
| const testName = "[sig-node] kubelet-log-collector detects node failed to lease events" | |||
| var failures []string | |||
|
|
|||
| intervalsToFailOn := findLeaseIntervalsImportant(finalIntervals) | |||
There was a problem hiding this comment.
need to filter this down to the type you're looking for, right?
| } | ||
| importantIntervals := monitorapi.Intervals(nil) | ||
| for _, val := range intervalsByNode { | ||
| if len(val) < 3 { |
There was a problem hiding this comment.
what if we reduce this to 2 so we flake if we get two instances and see how many hits we get?
kannon92
force-pushed
the
remove-lease-backoff
branch
from
d611d84
to
05af498
Compare
|
/retitle NO-JIRA: reduce node lease back off flames to 2 |
openshift-ci
bot
changed the title
|
@kannon92: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@kannon92: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -554,7 +554,7 @@ func findLeaseIntervalsImportant(intervals monitorapi.Intervals) monitorapi.Inte | |||
| } | |||
| importantIntervals := monitorapi.Intervals(nil) | |||
| for _, val := range intervalsByNode { | |||
| if len(val) < 3 { | |||
| if len(val) < 2 { | |||
| continue | |||
| } | |||
| for i, interval := range val { | |||
There was a problem hiding this comment.
in this for loop the 2s need to become 1s
No description provided.