Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix advisory inheritance and overrides #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adobes1
Copy link

@adobes1 adobes1 commented Sep 20, 2024

Fixes the following:

  1. Previously, when retrieving advisory IDs of a release which had advisories! defined, art-dash would use the advisories defined in the basis version (it would also not retrieve the corresponding jira ticket)
  2. When merging current_advisories and basis_advisories (or basis_override_advisories), art-dash would layer basis_advisories (or basis_override_advisories) over current_advisories. Now it is the opposite.

Also temporarily replace ./install.sh in the Dockerfiles with pip3 install -e artcommon/ -e doozer/ -e elliott/ -e pyartcd/ because ./install.sh is now using uv package manager and so far I couldn't get it to work inside the Dockerfiles.

Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ashwindasr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joepvd
Copy link
Contributor

joepvd commented Sep 20, 2024

Let's try and get uv installation to work :)

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants