Fix demo setup for dev (Basic UI + transform) #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Garnier <[email protected]>
lolodomo
changed the title
kaikreuzer
reviewed
Jun 29, 2024
| basicui:enableIcons=true | ||
| basicui:condensedLayout=false | ||
| basicui:capitalizeValues=false | ||
| basicui:inlineSvg=false |
There was a problem hiding this comment.
Could you briefly elaborate these changes? I am not fully clear, why they are done.
There was a problem hiding this comment.
Ah, ok, it is the demo setup and you simply removed the things that are anyhow the default values, I guess.
There was a problem hiding this comment.
The Basic UI settings are now on client side (browser).
They do not exist anymore on OH server side, except inlineSvg and defaultSitemap.
kaikreuzer
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laurent Garnier [email protected]