Merge pull request #12 from ahacart-adexos/hotfix/fix_type

Fix type to avoid type error due to strict type
opengento · Aug 16, 2022 · 9f4ec12 · 9f4ec12
2 parents b701f61 + 85818a9
commit 9f4ec12
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/Handler/RotatingFileHandler.php b/Handler/RotatingFileHandler.php
@@ -72,7 +72,7 @@ public function getInstance(): HandlerInterface
                 $this->directoryList->getPath(DirectoryList::VAR_DIR),
                 $this->scopeConfig->getValue($this->filenamePath)
             ),
-            $this->scopeConfig->getValue($this->maxFilesPath),
+            (int) $this->scopeConfig->getValue($this->maxFilesPath),
             $this->scopeConfig->getValue($this->levelPath)
         );
     }

diff --git a/Handler/SlackHandler.php b/Handler/SlackHandler.php
@@ -105,12 +105,12 @@ public function getInstance(): HandlerInterface
             $this->scopeConfig->getValue($this->tokenPath),
             $this->scopeConfig->getValue($this->channelPath),
             $this->scopeConfig->getValue($this->usernamePath),
-            $this->scopeConfig->getValue($this->useAttachmentPath),
+            $this->scopeConfig->isSetFlag($this->useAttachmentPath),
             $this->scopeConfig->getValue($this->iconEmojiPath),
             $this->scopeConfig->getValue($this->levelPath),
-            $this->scopeConfig->getValue($this->bubblePath),
-            $this->scopeConfig->getValue($this->useShortAttachmentPath),
-            $this->scopeConfig->getValue($this->includeContextAndExtraPath)
+            $this->scopeConfig->isSetFlag($this->bubblePath),
+            $this->scopeConfig->isSetFlag($this->useShortAttachmentPath),
+            $this->scopeConfig->isSetFlag($this->includeContextAndExtraPath)
         );
     }