Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove using namespace cuda from public header #3534

Conversation

VadimLevin
Copy link
Contributor

@VadimLevin VadimLevin commented Jul 19, 2023

Avoid using namespace statements in public header without any reason.

merge after opencv/opencv#24029 and opencv/opencv#24046

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov force-pushed the dev/vlevin/remove-using-namespace-public-cudacodec-header branch from f5ef56d to 68c708d Compare July 26, 2023 06:57
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov assigned asmorkalov and unassigned VadimLevin Jul 26, 2023
@asmorkalov asmorkalov merged commit 179021f into opencv:4.x Jul 26, 2023
6 of 7 checks passed
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants