Adapter fix/ust ist #1096
Merged
Adapter fix/ust ist #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #1095 |
Also some util methods and guides
caparker
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Looks good. I removed a log line from the top of the file where you were logging out the value of yesterday. If that is something you wanted to leave in there then just add more to the log, like
log.debug('Showing value of yesterday', yesterday)
Or something along those lines. Otherwise I will assume it was just for dev purposes and you meant to remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapter data URL
https://api.ust.is/aq/a/getLatestdoes not appear to return data anymore. This has been replaced withhttps://api.ust.is/aq/a/getDate/date/${yesterday}. The URL seem to only work up till the day before the current date unfortunately but does return measurements. Endpoints can be investigated athttps://api.ust.is/aq/a.It has also been updated to over-fetch measurements to help with coverage.