[nuget] add publish warning when RuntimeIdentifier is not specified #3601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Warn when an app uses autoinstrumentation NuGet package, and is published without specifying runtime identifier.
In such scenario, native profiler libraries for all of the supported platforms are copied to the publish output directory, which results in increased disk usage.
Fixes #
What
DisableAutoInstrumentationCheckForRuntimeIdentifier
propertyI considered making target run before build instead of publish, and issue an Error instead of a Warning (would be consistent with other target), but decided it would be to noisy/restrictive. Let me know if you think I should change the approach.
Tests
Included in PR.
Checklist
CHANGELOG.md
is updated.