Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add @gwslingerland as a contributor #466

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gwslingerland
Copy link

@gwslingerland gwslingerland commented Sep 12, 2024

Description

What type of PR is this? (check all applicable)

  • 🤝 Add a contributor
  • 📝 Documentation Update

Related Issues

Solves issue #465

Contributors Checklist

I've read through the Getting Started section.

  • ✅ Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • ✅ Yes
  • ❌ No

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Screenshot (Required for PR Review)

afbeelding

[optional] What GIF best describes this PR or how it makes you feel?

@gwslingerland gwslingerland requested a review from a team as a code owner September 12, 2024 19:41
Copy link

Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @gwslingerland! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in the next chapter and share it with us!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

@adiati98
Copy link
Member

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Hi @gwslingerland,
Thank you for your contribution! ✨

Can you please address above message until all checks pass?

Also, we have merged a PR before yours. You need to resolve the conflicts before we can review your PR.

Let me know if you need any help. Thanks. 😊

@gwslingerland
Copy link
Author

i resolved the issues in my forked repo. Do i need to create a new pull-request or is it automatically updated?

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gwslingerland,
Answering your question, you don't need to create new PR. It's automatically updated once you pushed your changes.

However, there are some issues that need to be fixed here:

  • Some contributors' profile in .all-contributorsrc file are deleted and we don't want that.
  • You haven't removed the opening and closing === that mark the conflicts on the README.
  • You haven't run the command to generate the profile after resolving the conflicts. Once you run this, the badge should increase.

Another thing is, the check is still not passed because you use the word Solves issue before your issue number. The keyword rule for GitHub is strict. So you need to use the keyword Resolves follow by your issue number.

What you can do to resolve conflicts:

  • Undo the pushed commit to before you resolved the conflicts. You can read this blog post to do that.
  • Please read through the instructions to resolve the conflicts in this repo as I linked in my previous comment.

Do let me know if you have questions. Thanks. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants