Feat/finalizer #61
Open
Feat/finalizer #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finalizerの処理メモ フラグ
各フロー
|
tak1827
commented
Sep 5, 2024
| @@ -48,7 +50,8 @@ var deploymentSets = map[common.Hash]map[uint64]deploymentSet{ | |||
| deployments8, | |||
| deployments9, | |||
| deployments10, | |||
| deployments11, | |||
| // deployments11, // Disable this feature as it changes the epoch, which can impact development. | |||
There was a problem hiding this comment.
private opstackではdeployments11をdisableにしました。
| @@ -80,59 +80,3 @@ func TestEnvironmentValue(t *testing.T) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func TestNewEnvironmentValue(t *testing.T) { | |||
| @@ -1078,6 +1078,7 @@ func (w *worker) commitWork(interrupt *atomic.Int32, timestamp int64) { | |||
| coinbase: coinbase, | |||
| }) | |||
| if err != nil { | |||
| log.Error("Failed to prepare work", "in", "commitWork", "err", err) | |||
| votesSub event.Subscription | ||
|
|
||
| voteMonitorSub event.Subscription | ||
| maliciousVoteMonitor *monitor.MaliciousVoteMonitor |
There was a problem hiding this comment.
MuliciousVoteMonitorはマージしただけ。動作未確認。
| @@ -165,7 +165,7 @@ func FromECDSA(priv *ecdsa.PrivateKey) []byte { | |||
|
|
|||
| // UnmarshalPubkey converts bytes to a secp256k1 public key. | |||
| func UnmarshalPubkey(pub []byte) (*ecdsa.PublicKey, error) { | |||
| x, y := elliptic.Unmarshal(S256(), pub) | |||
| x, y := elliptic.Unmarshal(S256(), pub) //nolint:all //TODO | |||
There was a problem hiding this comment.
LinterのWarningを無視。BSCと同じ形にした。
| if err != nil { | ||
| log.Error("Failed to get scheduler", "in", "verifyCascadingFields", "number", number, "err", err) | ||
| return err | ||
| return fmt.Errorf("failed to get scheduler. blockNumber: %d, in: verifyCascadingFields, err: %v", number, err) |
There was a problem hiding this comment.
ログでエラーを吐くよりも、Errorの中身を詳細にした。
| } | ||
| } | ||
| // the voter's total stake should be greater than 2/3 of the total stake | ||
| threshold := new(big.Int).Mul(totalStake, big.NewInt(2)) |
| // getValidatorsFromHeader returns the next validators extracted from the header's extra field if exists. | ||
| // The validators bytes would be contained only in the epoch block's header, and its each validator bytes length is fixed. | ||
| // Layout: |--Extra Vanity--|--EnvironmentValue--| --Validator Number--|--Owner(or Empty)--|--Operator(or Empty)--|---Stake(or Empty)--|--Vote Address(or Empty)--|--Vote Attestation(or Empty)--|--Extra Seal--| | ||
| func getValidatorsFromHeader(header *types.Header) (*nextValidators, error) { |
There was a problem hiding this comment.
Env/Validator/VoteAttestationをHeaderに詰め込む
| @@ -816,10 +1174,25 @@ func (c *Oasys) Seal(chain consensus.ChainHeaderReader, block *types.Block, resu | |||
| case <-time.After(delay): | |||
| } | |||
|
|
|||
| err := c.assembleVoteAttestation(chain, header, validators) | |||
| for i, voteAddr := range validators.VoteAddresses { | ||
| if _, ok := voteAddrSet[voteAddr]; ok { | ||
| voterIndex := i + 1 | ||
| attestation.VoteAddressSet |= 1 << voterIndex |
There was a problem hiding this comment.
AttestationのVoterIndexはOwner鍵でソートされた順序で決まる
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast FinalityをBSCのv1.4.6から移植しました。
差分が多いです。新規のファイルは基本的にいじっていません。僕が加えた変更は主にConsensusに集中しています。
気になるところをコメントに残しました。また、処理メモも下に残しました。
動作確認は、private-opstackのfeat/support-finalizerで可能です。updateBLSKeyボタンを押して、BLS鍵を登録する必要があります。