Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update realpath.js to fix https://github.com/npm/cli/issues/7309 #7757

Open
wants to merge 3 commits into
base: latest
Choose a base branch
from
Open

Update realpath.js to fix https://github.com/npm/cli/issues/7309 #7757

wants to merge 3 commits into from

Conversation

BenMcLean
Copy link

@BenMcLean BenMcLean commented Aug 28, 2024 •
edited
Loading

This fixes #7309 which causes a "RangeError: Maximum call stack size exceeded" on line 38 on Windows 11 without this change.

References

@danFbach found the fix.

@BenMcLean BenMcLean requested a review from a team as a code owner August 28, 2024 16:21
@wraithgar
Copy link
Member

The == is probably going to fail linting (should be ===) and this will need a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] npm arborist realpath.js with UNC paths
2 participants
@BenMcLean @wraithgar