fix: Fix npm install --prefix on windows #7725
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that globalDir/localDir and globalPrefix/localPrefix end up being the same value when `--prefix` is set. This was surprising to me, but it does appear that `globalPrefix` is set to match `prefix` at the end of loading. This means that the globalTop logic is actually incorrect here. It accidentally worked on non-windows machines. For example if running `npm i --prefix scripts` On non-windows this.npm.globalDir = $CWD/scripts/lib/node_modules On windows this.npm.globalDir = $CWD/scripts/node_modules IMHO, the logic inside of npmconfig is also incorrect here, since globalDir is being set to this bogus `$CWD/scripts/lib/node_modules` However, this fix should work regardless - since it stops relying on the specific values of globalDir. Fixes npm#7722 I manually tested `npm install` and `npm install --prefix` on both windows and mac. Everything works now.
2 tasks
|
This needs tests |
|
good idea. I'll see when I can make some time for it. install.test.js has some examples which I had taken a quick pass over. It was a little hard to figure out how to get the equivalent of If anyone out there reading this has time to offer help, I'd take it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that globalDir/localDir and globalPrefix/localPrefix end up being the same value when
--prefixis set. This was surprising to me, but it does appear thatglobalPrefixis set to matchprefixat the end of loading.This means that the globalTop logic is actually incorrect here. It accidentally worked on non-windows machines.
For example if running
npm i --prefix scriptsOn non-windows
this.npm.globalDir = $CWD/scripts/lib/node_modules
On windows
this.npm.globalDir = $CWD/scripts/node_modules
IMHO, the logic inside of npmconfig is also incorrect here, since globalDir is being set to this bogus
$CWD/scripts/lib/node_modulesHowever, this fix should work regardless - since it stops relying on the specific values of globalDir.
I manually tested
npm installandnpm install --prefixon both windows and mac. Everything works now.References
Fixes #7722