Merge pull request #51 from Eazybright/fix/update-test-suites

fix: update test suite to use named argument during client initialization
novuhq · Jan 16, 2024 · 704964b · 704964b
2 parents 151fec2 + 075a9f3
commit 704964b
Show file tree

Hide file tree

Showing 17 changed files with 17 additions and 33 deletions.
diff --git a/bin/console b/bin/console
@@ -12,4 +12,4 @@ require "novu"
 # Pry.start
 
 require "irb"
-IRB.start(__FILE__)
+IRB.start(__FILE__)
diff --git a/spec/blueprints_spec.rb b/spec/blueprints_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::Blueprints do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
 
   describe "#get_blueprint" do

diff --git a/spec/changes_spec.rb b/spec/changes_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::Changes do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
 
   describe "#changes" do

diff --git a/spec/environments_spec.rb b/spec/environments_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::Environments do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
 
   describe "#environment" do

diff --git a/spec/events_spec.rb b/spec/events_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::Events do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
 
   describe "#trigger_event" do

diff --git a/spec/execution_details_spec.rb b/spec/execution_details_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::ExecutionDetails do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
 
   describe "#execution_details" do

diff --git a/spec/feeds_spec.rb b/spec/feeds_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::Feeds do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
 
   describe "#create_feed" do

diff --git a/spec/inbound_parse_spec.rb b/spec/inbound_parse_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::InboundParse do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
   let(:subscriber_id) { "63f71b3ef067290fa669106d" }
 

diff --git a/spec/integrations_spec.rb b/spec/integrations_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::Integrations do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
 
   describe "#integrations" do

diff --git a/spec/layouts_spec.rb b/spec/layouts_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::Layouts do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
   let(:layout_id) { "63f71b3ef067290fa669106d" }
 

diff --git a/spec/messsages_spec.rb b/spec/messsages_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::Messages do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
 
   describe "#message" do

diff --git a/spec/notification_groups_spec.rb b/spec/notification_groups_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::NotificationGroups do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
 
   describe "#create_notification_group" do

diff --git a/spec/notification_spec.rb b/spec/notification_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::Notification do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
 
   describe "#notifications" do

diff --git a/spec/notification_templates_spec.rb b/spec/notification_templates_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::NotificationTemplates do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
   let(:template_id) { "63f71b3ef067290fa669106d" }
 

diff --git a/spec/subscribers_spec.rb b/spec/subscribers_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::Subscribers do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
   let(:subscriber_id) { "63f71b3ef067290fa669106d" }
 

diff --git a/spec/tenants_spec.rb b/spec/tenants_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::Tenants do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
   let(:identifier) { "a_unique_string" }
 

diff --git a/spec/topics_spec.rb b/spec/topics_spec.rb
@@ -1,11 +1,10 @@
 # frozen_string_literal: true
 
-require "spec_helper"
 require_relative "../lib/novu"
 
 RSpec.describe Novu::Api::Topics do
   let(:access_token) { "1234567890" }
-  let(:client) { Novu::Client.new(access_token) }
+  let(:client) { Novu::Client.new(access_token: access_token) }
   let(:base_uri) { "https://api.novu.co/v1" }
   let(:topic_key) { "test-topic" }