Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaceability using other tags #1510

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

replaceability using other tags #1510

wants to merge 1 commit into from

Conversation

fiatjaf
Copy link
Member

@fiatjaf fiatjaf commented Sep 21, 2024

This might be a solution to the #1501 conundrum (we can just grandfather in that specific kind like we did with normal replaceables and kinds 0 and 3).

And also address #1506 and other similar issues that will certainly arrive in the future.

Just a preliminary idea.

@alexgleason
Copy link
Member

I like this approach.

Another idea I had was to give the "d" tag a second parameter, something like this:

[
  ["d", eventId, "e"],
  ["e", eventId, ...rest],
]

or:

[
  ["d", pubkey, "p"],
  ["p", pubkey, ...rest],
]

When the "d" tag has this extra parameter, there MUST be a matching tag.

@kehiy
Copy link
Contributor

kehiy commented Sep 21, 2024

the current filter/event model is complex (better to say dynamic) enough to be hard to store and query efficiently. i think putting more dynamic rule on them just makes the relay implementation more complex. also make them inefficient. also clients.

if i understand this nip correctly, it will affect a lof of stuff in the processing "EVENT"s and "REQ"s. maybe I'm wrong? not sure.

@mikedilger
Copy link
Contributor

I don't think this is worth it. Adding a 'd' tag that matches the 'e' or 'p' or 'a' isn't that much overhead, but it is a lot of coding to do it this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants