Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nip29: support for unmanaged groups, top-level relay-local groups and invite codes #1496

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fiatjaf
Copy link
Member

@fiatjaf fiatjaf commented Sep 13, 2024

This basically allows NIP-29 to be used without any moderation in normal relays and the usage of these relays as groups. These can later upgrade to fully moderated relays.

It is a counterproposal to #1495.

This PR subsumes #1493.

Group identifiers must be strings restricted to the characters `a-z0-9-_`.

When encountering just the `<host>` without the `'<group-id>`, clients can choose to connect to the group with id `_`, which is a special top-level group dedicated to relay-local discussions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we can add UUID recommendations and why relays may reject some id.

Also, above we defined the id's. here we defined a way to find a group using id and host, combined. which I believe MUST be replaced with names in future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we can close #1493.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UUID is excessively big and unnecessary, I don't think we should recommend it although some people may want to use it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not plan to use id's for users at all. also on the other hand for example 0xchat is generating very big id's larger than UUIDs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is a bug in 0xchat then, and also relays should block giant ids.

@staab
Copy link
Member

staab commented Sep 13, 2024

NIP 29 needed less complexity, not more!

@kehiy
Copy link
Contributor

kehiy commented Sep 18, 2024

any updates on this??

@staab
Copy link
Member

staab commented Sep 18, 2024

I've written my own counter-proposal on #1495

@kehiy
Copy link
Contributor

kehiy commented Sep 18, 2024

got it, will check it. thanks.

Copy link

@ismyhc ismyhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good change to simplifying group moderation, etc. Allow the relay to predetermine role names and a capabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants