-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement WebSocketStream #3560
Open
KhafraDev
wants to merge
19
commits into
nodejs:main
Choose a base branch
from
KhafraDev:websocketstream-again
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhafraDev
force-pushed
the
websocketstream-again
branch
from
September 7, 2024 23:11
1c931a2
to
deae218
Compare
KhafraDev
force-pushed
the
websocketstream-again
branch
from
September 8, 2024 17:29
58d5072
to
1237174
Compare
@nodejs/undici This passes the same subset of WebSocketStream tests that Deno passes. It's missing types and docs now. Looking for code reviews before doing the trivial stuff. |
Uzlopak
reviewed
Sep 9, 2024
Uzlopak
reviewed
Sep 9, 2024
Uzlopak
reviewed
Sep 9, 2024
Uzlopak
reviewed
Sep 9, 2024
Uzlopak
reviewed
Sep 9, 2024
Uzlopak
reviewed
Sep 9, 2024
Uzlopak
reviewed
Sep 9, 2024
Uzlopak
reviewed
Sep 9, 2024
Uzlopak
reviewed
Sep 9, 2024
Uzlopak
reviewed
Sep 9, 2024
Uzlopak
reviewed
Sep 9, 2024
Uzlopak
reviewed
Sep 9, 2024
try { | ||
string = webidl.converters.USVString(chunk) | ||
} catch (e) { | ||
return Promise.reject(e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldnt we reuse the already created deferred promise?
return promise.reject(e)
?
Uzlopak
reviewed
Sep 9, 2024
tsctx
reviewed
Sep 9, 2024
tsctx
reviewed
Sep 9, 2024
tsctx
reviewed
Sep 9, 2024
tsctx
reviewed
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With better-organized internals, this is now much easier and almost completely detached from WebSocket. I could rewrite it to be completely independent of WebSocket, which would allow us to remove it at any time (the only shared internals are a new
getURLRecord
function and the closing logic).