Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add flag to drop connection when running in cluster mode #54927

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lib: add flag to drop connection when running in cluster mode #54927

wants to merge 1 commit into from
+39 −3

Conversation

theanarkh
Copy link
Contributor

Refs: #54882

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. needs-ci PRs that need a full CI run. labels Sep 13, 2024
RedYetiDev
RedYetiDev reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@RedYetiDev RedYetiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicks for the documentation

doc/api/net.md Outdated Show resolved Hide resolved
doc/api/net.md Outdated Show resolved Hide resolved
@RedYetiDev RedYetiDev added the net Issues and PRs related to the net subsystem. label Sep 13, 2024
@theanarkh theanarkh force-pushed the drop_connection_when_reach_max_connection branch from 59f2e8d to 446f9ff Compare September 13, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedYetiDev RedYetiDev RedYetiDev left review comments

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theanarkh @nodejs-github-bot @RedYetiDev