Migrate NcModal to NcDialog
#1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
reviewed
Jul 25, 2024
JuliaKirschenheuter
added
2. developing
JuliaKirschenheuter
force-pushed
the
bugfix-1213-Migrate-from-NcModal-to-NcDialog
branch
2 times, most recently
from
adf2762
to
3bd4b7a
Compare
elzody
approved these changes
Aug 1, 2024
juliushaertl
force-pushed
the
bugfix-1213-Migrate-from-NcModal-to-NcDialog
branch
from
3bd4b7a
to
02fcb31
Compare
|
Took the liberty to rebase and push a small adjustment for the cypress selectors that read the heading of the modals so we can get this in :) |
JuliaKirschenheuter
force-pushed
the
bugfix-1213-Migrate-from-NcModal-to-NcDialog
branch
from
02fcb31
to
873fd22
Compare
juliushaertl
reviewed
Aug 5, 2024
| <NcModal v-if="showModal" size="large" @close="actionCancel"> | ||
| <NcDialog v-if="showModal" | ||
| :name="t('tables', 'Create column')" | ||
| size="large" |
There was a problem hiding this comment.
Could we also pass the buttons to the actions slot? That should make them sticky at the bottom of the modal so they are not hidden behind scroll bars
juliushaertl
force-pushed
the
bugfix-1213-Migrate-from-NcModal-to-NcDialog
branch
from
873fd22
to
e3602a0
Compare
Signed-off-by: julia.kirschenheuter <[email protected]>
juliushaertl
force-pushed
the
bugfix-1213-Migrate-from-NcModal-to-NcDialog
branch
from
e3602a0
to
41148d0
Compare
juliushaertl
approved these changes
Aug 29, 2024
juliushaertl
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1213
Reviewers: please test
FileActionImport.vuedialog, because i was not able to see it in UI