fix: Remove deleted resource from associated applications #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤔 I thought we/I did it in the past 😕 |
juliushaertl
previously requested changes
Jun 26, 2024
enjeck
force-pushed
the
fix/1027
branch
2 times, most recently
from
b3d731e
to
90a346c
Compare
enjeck
force-pushed
the
fix/1027
branch
2 times, most recently
from
b3d731e
to
d5da0f2
Compare
enjeck
force-pushed
the
fix/1027
branch
2 times, most recently
from
40a7aaa
to
0af1177
Compare
enjeck
force-pushed
the
fix/1027
branch
2 times, most recently
from
71fe642
to
c7d8245
Compare
Signed-off-by: Cleopatra Enjeck M <[email protected]>
Signed-off-by: Cleopatra Enjeck M <[email protected]>
Signed-off-by: Cleopatra Enjeck M <[email protected]>
juliushaertl
approved these changes
Aug 29, 2024
@blizzz Anything you'd want to still check in that regard? |
I would fancy a database clean up (could be a run-once expensive/maintenance background job), but this can be a follow-up PR. Which can then also be dropped in a future version, still good practice to keep the DB neat and tidy. |
blizzz
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1027