fix(federation): Do not overwrite certificate bundle

[juliushaertl]

Signed-off-by: Julius Härtl [email protected]

• Resolves: #

Summary

One might still want to verify self-signed certificates and not disable verification entirely. Before this change the verify option was always overwritten with true which means that the system certificate store was used instead of the Nextcloud built in one. We should only pass verify if we actually intent to disable verification, else the http client is injecting the cert bundle properly in

server/lib/private/Http/Client/Client.php

Line 55 in dae7c15

RequestOptions::VERIFY => $this->getCertBundle(),

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[juliushaertl]

Added some more cases that I noticed when trying to debug something with @Antreesy where the request failed silently to also make use of the setting and log errors in apps/files_sharing/lib/External/Storage.php