Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy labels when moving cards between boards #6257

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

grnd-alt
Copy link
Member

  • Target version: main

Summary

labels assigned to cards that move between boards now get cloned
old json deck files that have cross referencing labels now skip those labels instead of throwing an error

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@stefan-niedermann
Copy link
Member

I did a quick code review and I am wondering whether or not there should be permission check (I think the "manage board" permission is required when a user wants to create new labels)?

@grnd-alt grnd-alt force-pushed the fix/no-cross-referencing-in-labels branch from 8718bbd to dbca6bc Compare August 28, 2024 09:59
@juliushaertl juliushaertl merged commit 43a0fec into main Aug 29, 2024
35 checks passed
@juliushaertl juliushaertl deleted the fix/no-cross-referencing-in-labels branch August 29, 2024 10:30
@juliushaertl
Copy link
Member

@grnd-alt Backports?

@grnd-alt
Copy link
Member Author

grnd-alt commented Sep 2, 2024

/backport to stable28

@grnd-alt
Copy link
Member Author

grnd-alt commented Sep 2, 2024

/backport to stable29

@grnd-alt
Copy link
Member Author

grnd-alt commented Sep 2, 2024

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

3 participants