Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: add network policy #5024

Merged
merged 2 commits into from
Jul 25, 2024
Merged

helm: add network policy #5024

merged 2 commits into from
Jul 25, 2024

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Jul 22, 2024 •
edited by st3iny
Loading

  • needs testing if it works with global ingress (that runs in different namespace usually)

@szaimen szaimen added 2. developing Work in progress enhancement New feature or request labels Jul 22, 2024
@szaimen szaimen added this to the next milestone Jul 22, 2024
@szaimen szaimen force-pushed the enh/noid/add-network-policy branch 2 times, most recently from 39f0f65 to e78d3ae Compare July 22, 2024 14:11
@szaimen szaimen marked this pull request as ready for review July 22, 2024 14:11
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 22, 2024
@szaimen szaimen requested a review from st3iny July 22, 2024 14:11
@st3iny
Copy link
Member

st3iny commented Jul 22, 2024

I'll set up a network policy plugin locally and give this a test.

@szaimen
Copy link
Collaborator Author

szaimen commented Jul 22, 2024

I'll set up a network policy plugin locally and give this a test.

So network policies are not included by default? Should we make it possible to disable this then?

@st3iny
Copy link
Member

st3iny commented Jul 23, 2024

So network policies are not included by default? Should we make it possible to disable this then?

Policies are always available but will be ignored by some CNI plugins.

So we can always apply them but the cluster needs a CNI with policy support (e.g. Calico) for them to actually have an impact.

st3iny

This comment was marked as resolved.

Sign in to view

@szaimen szaimen force-pushed the enh/noid/add-network-policy branch from e78d3ae to 8a9c5ae Compare July 24, 2024 14:06
@szaimen szaimen requested a review from st3iny July 24, 2024 14:07
st3iny
st3iny reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and left some suggested changes.

nextcloud-aio-helm-chart/templates/nextcloud-aio-networkpolicy.yaml Outdated Show resolved Hide resolved
@szaimen
address review
533c270 
Signed-off-by: Simon L. <[email protected]>
@szaimen szaimen merged commit 00c4162 into main Jul 25, 2024
4 checks passed
@szaimen szaimen deleted the enh/noid/add-network-policy branch July 25, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny left review comments

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
v9.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@szaimen @st3iny