Ruby kafka gem instrumentation #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannalynn
requested review from
fallwith,
hannahramadan and
kaylareopelle
as code owners
fallwith
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Few small docs things. I agree with @fallwith's suggestion to lock down the versions tested in the CI.
Looks good otherwise! Thank you!
Co-authored-by: Kayla Reopelle <[email protected]>
Co-authored-by: Kayla Reopelle <[email protected]>
Co-authored-by: Kayla Reopelle <[email protected]>
…m is no longer maintained
…newrelic-ruby-agent into ruby_kafka_gem_instrumentation
fallwith
reviewed
Sep 11, 2024
Co-authored-by: James Bunch <[email protected]>
SimpleCov Report
|
fallwith
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds instrumentation for the ruby-kafka gem.
full ci run: https://github.com/newrelic/newrelic-ruby-agent/actions/runs/10795710672