Support Aws kinesis V1 and V2 SDKs #2031
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2031 +/- ##
============================================
- Coverage 70.57% 70.56% -0.02%
+ Complexity 9874 9872 -2
============================================
Files 829 829
Lines 39935 39945 +10
Branches 6079 6078 -1
============================================
+ Hits 28186 28187 +1
- Misses 9019 9024 +5
- Partials 2730 2734 +4 ☔ View full report in Codecov by Sentry. |
obenkenobi
changed the title
| } | ||
|
|
||
| public static CloudParameters createCloudParams() { | ||
| // Todo: add arn to cloud parameters |
There was a problem hiding this comment.
Is this still a TODO? Is a separate method necessary at just 1 line?
There was a problem hiding this comment.
Yes, there is a separate ticket for reporting the ARN for kinesis, I am simply adding the todo for when I begin this ticket.
| tracedMethod.reportAsExternal(createCloudParams()); | ||
| } | ||
| public static CloudParameters createCloudParams() { | ||
| // Todo: add arn to cloud parameters |
There was a problem hiding this comment.
Is this still a TODO? Is a separate method necessary at just 1 line?
There was a problem hiding this comment.
This is a repeat of what I said in another comment:
Yes, there is a separate ticket for reporting the ARN for kinesis, I am simply adding the todo for when I begin this ticket.
Overview
Add support for adding external cloud traces for customers using AWS Kinesis v1 and v2 SDKs
Related Github Issue
#2016