feat: Upgrade to web-vitals v4 #1193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old `event*` attrs are preserved to ease v3 to v4 transition for customers/any internal refs. The only exception is `eventType`, which is replaced due to being a reserved keyword in NRDB.
Note: interactionTargetElement, processedEventEntries, and longAnimationFrameEntries are excluded.
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
- Coverage 88.38% 88.37% -0.01%
==========================================
Files 164 164
Lines 7229 7228 -1
Branches 1478 1478
==========================================
- Hits 6389 6388 -1
Misses 722 722
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ptang-nr
changed the title
ptang-nr
changed the title
cwli24
reviewed
Sep 19, 2024
Co-authored-by: Chunwai Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to web-vitals v4. For more info, please see https://github.com/GoogleChrome/web-vitals/blob/main/docs/upgrading-to-v4.md.
Overview
In this PR, we are upgrading to current latest web-vitals lib (v4.2.3) following the web-vitals upgrade doc.
Notable changes:
INP
eventTypeis renamed tointeractionTypeto avoid keyword conflict within NRinteraction*equivalents for otherevent*attrs in useevent*attrs are preserved for backwards compatibility to be EOL'd at a later timeLCP
resourceLoadTimeas replacement forresourceLoadDurationresourceLoadDurationis preserved for backwards compatibility to be EOL'd at a later timeRelated Issue(s)
https://new-relic.atlassian.net/browse/NR-296095
Testing
Relevant web-vital unit tests + PVT integration tests