Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max height to images #938

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Add max height to images #938

merged 5 commits into from
Dec 8, 2023

Conversation

tabathadelane
Copy link
Contributor

@tabathadelane tabathadelane commented Jul 24, 2023

  • also provides an 'unbound' class to unset this style
  • Styles are also unset within the lightbox view

height restricted image in its full size in lightbox:
Screenshot 2023-09-13 at 3 48 15 PM

TODO:
images where the width has been set to a percent in the mdx file are stretching when the max height is reached:
Screenshot 2023-09-13 at 4 26 19 PM

- also provides an 'unbound' class to unset this style
@tabathadelane tabathadelane requested a review from a team as a code owner July 24, 2023 20:30
@tabathadelane tabathadelane requested review from sunnyzanchi and clarkmcadoo and removed request for a team July 24, 2023 20:30
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 24, 2023

✅ gatsby-theme-newrelic-develop deploy preview ready

@tabathadelane tabathadelane merged commit 2a8c271 into develop Dec 8, 2023
6 checks passed
@tabathadelane tabathadelane deleted the tabatha/max-image-height branch December 8, 2023 18:25
tabathadelane added a commit that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants