Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(K8s): fixing what's new #18716

Merged
merged 3 commits into from
Sep 19, 2024
Merged

fix(K8s): fixing what's new #18716

merged 3 commits into from
Sep 19, 2024

Conversation

jeff-colucci
Copy link
Contributor

No description provided.

@jeff-colucci jeff-colucci added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Sep 19, 2024
@jeff-colucci jeff-colucci self-assigned this Sep 19, 2024
Copy link

Hi @jeff-colucci 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/66ec66d6322d5d2e791312d1
😎 Deploy Preview https://deploy-preview-18716--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

paperclypse
paperclypse previously approved these changes Sep 19, 2024
Copy link
Contributor

@paperclypse paperclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just adding the .md file suffix?

@jeff-colucci
Copy link
Contributor Author

Correct, this just needs the correct file tag to show up in the WN nav I believe. It didn't have one in the original PR, but the weird thing was it was actually showing up in the build preview so I didn't think there was any actual issue.

Either way, it should be fixed now!

@jeff-colucci
Copy link
Contributor Author

The only change between this and the review was a fix to the image formatting so I'm going to push it out since it built successfully.

@jeff-colucci jeff-colucci merged commit 07b6588 into develop Sep 19, 2024
20 checks passed
@jeff-colucci jeff-colucci deleted the what's-new-fix branch September 19, 2024 18:18

![LogsMiniOverviewWidget](/images/WhatsNewMiniOverviewWidgetInKubernetesDeploymentSummaryPage.webp "A screenshot showing the LogsMiniOverviewWidget in the kubernetes deployment summary page")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeff-colucci There's a stray square bracket at the very end of this line that needs to be deleted, once you do that, and the builds finish, feel free to merge it in

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![LogsMiniOverviewWidget](/images/WhatsNewMiniOverviewWidgetInKubernetesDeploymentSummaryPage.webp "A screenshot showing the LogsMiniOverviewWidget in the kubernetes deployment summary page")]
![LogsMiniOverviewWidget](/images/WhatsNewMiniOverviewWidgetInKubernetesDeploymentSummaryPage.webp "A screenshot showing the LogsMiniOverviewWidget in the kubernetes deployment summary page")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants