-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(K8s): fixing what's new #18716
fix(K8s): fixing what's new #18716
Conversation
Hi @jeff-colucci 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just adding the .md file suffix?
Correct, this just needs the correct file tag to show up in the WN nav I believe. It didn't have one in the original PR, but the weird thing was it was actually showing up in the build preview so I didn't think there was any actual issue. Either way, it should be fixed now! |
The only change between this and the review was a fix to the image formatting so I'm going to push it out since it built successfully. |
|
||
![LogsMiniOverviewWidget](/images/WhatsNewMiniOverviewWidgetInKubernetesDeploymentSummaryPage.webp "A screenshot showing the LogsMiniOverviewWidget in the kubernetes deployment summary page")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeff-colucci There's a stray square bracket at the very end of this line that needs to be deleted, once you do that, and the builds finish, feel free to merge it in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![LogsMiniOverviewWidget](/images/WhatsNewMiniOverviewWidgetInKubernetesDeploymentSummaryPage.webp "A screenshot showing the LogsMiniOverviewWidget in the kubernetes deployment summary page")] | |
![LogsMiniOverviewWidget](/images/WhatsNewMiniOverviewWidgetInKubernetesDeploymentSummaryPage.webp "A screenshot showing the LogsMiniOverviewWidget in the kubernetes deployment summary page") |
No description provided.