Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET logging framework compatability info #15527

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Update .NET logging framework compatability info #15527

merged 4 commits into from
Dec 14, 2023

Conversation

brnhensley
Copy link
Contributor

@brnhensley brnhensley commented Dec 14, 2023

Updated the individual compatibility docs for Core and Framework. I replaced the known compatible versions with minimum versions and agent versions. Known compatible version lists are really tough to keep up to date and I'm not sure they are as valuable as a list of minimums or versions with known issues.

I also replaced the confusing bullet point list of compatibility info in the LIC doc with a table that is easier to read.

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

the table was incomplete and missing details, I re-organized it and updated it
also replaced known compatible versions because we will never be able to keep that list up to date. Replaced it with minimum agent version which is important for customers
Copy link

Hi @brnhensley 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@brnhensley brnhensley marked this pull request as draft December 14, 2023 18:58
@brnhensley brnhensley marked this pull request as ready for review December 14, 2023 19:02
Copy link
Contributor

@jeff-colucci jeff-colucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we can publish once the verify-mdx failure resolves itself!

@jeff-colucci jeff-colucci self-assigned this Dec 14, 2023
@jeff-colucci jeff-colucci added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Dec 14, 2023
Copy link

gatsby-cloud bot commented Dec 14, 2023

✅ docs-website-develop deploy preview ready

@jeff-colucci
Copy link
Contributor

Publishing with failed verify-mdx as the only gating error is the /docs/new-relic-solutions/new-relic-one/core-concepts/new-relic-ai.mdx bug.

@jeff-colucci jeff-colucci merged commit c0a805a into newrelic:develop Dec 14, 2023
13 of 14 checks passed
@brnhensley brnhensley deleted the patch-3 branch December 18, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants