-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add GKE Autopilot configuration doc #15496
feat: Add GKE Autopilot configuration doc #15496
Conversation
Hi @svetlanabrennan 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes). |
✅ docs-website-develop deploy preview ready
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me.
First round of edits to get these in a state ready for publication. These will need further revision as they currently reference other tabs. Needs to be revised to live more holistically within the structure of the doc.
|
||
There are three ways to install the Kubernetes integration in your GKE Autopilot cluster. | ||
|
||
<CollapserGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradleycamacho and @svetlanabrennan: What differentiates these collapsers from the guided install and Manual Helm steps from the other two tabs? I see that these aren't sequential, but maybe something that clarifies whether they're the same steps or separate
@@ -56,6 +56,7 @@ To install our Kubernetes integration, we recommend that you follow the instruct | |||
<TabsBarItem id="2">In Windows</TabsBarItem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a call out about the right nav defaulting to the h2s in the guided install steps, even if you click across different install options. Until Eng has capacity to make the right nav dynamic with the horiz tabs, we might consider switching the headers in step component to h3s.
</Collapser> | ||
<Collapser | ||
id="helm-gke" | ||
title="Manual Helm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the other two collapsers are duplicative of content in the other tabs, we might consider prioritizing these steps first ahead of guided install / helm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK It took a min to grok but I see the differentiation. I'd still add some context about the action users are going to do that are ~different from the horiz tabs, just to avoid confusion. Suggestion tho! I'm not the intended audience
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Please follow conventional commit standards
in your commit messages and pull request title.
Give us some context
The nri-bundle now supported in GKE Autopilot. This pr ads config docs to install in GKE Autopilot.
links to related docs, screenshots, etc.