fix(PHP): Clarify browser auto-instrumentation #15436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin-schaefer
added
content
|
Hi @austin-schaefer 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes). |
paperclypse
reviewed
Dec 7, 2023
src/content/docs/apm/agents/php-agent/features/browser-monitoring-php-agent.mdx
Outdated
Show resolved
Hide resolved
paperclypse
reviewed
Dec 7, 2023
src/content/docs/apm/agents/php-agent/features/browser-monitoring-php-agent.mdx
Outdated
Show resolved
Hide resolved
paperclypse
previously approved these changes
Dec 7, 2023
There was a problem hiding this comment.
@austin-schaefer Had some suggestions on how to clarify this wording. Take it or leave it, as you like :)
Co-authored-by: Shawn Kilburn <[email protected]>
|
@paperclypse : Much better after your wording tweaks, thank you! Mind giving it a quick re-approve? |
paperclypse
approved these changes
Dec 7, 2023
✅ docs-website-develop deploy preview ready
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: I'm not sure my wording here is very elegant. The goal is to convey that this happens out of the box; the doc as-written doesn't do a good job indicating this just works automagically in most cases.