Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: instrument plugin version pinning #5582

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JGAntunes
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #<replace_with_issue_number>


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@JGAntunes JGAntunes self-assigned this Apr 4, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

import { getMajorVersion, isPrerelease } from '../utils/semver.js'

const tracer = wrapTracer(trace.getTracer('plugins'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a problem, just FYI:
If you are not using new methods like with(Active)Span from wrapped / sugared tracer - this is no-op as it will just inherit regular tracer start(Active)Span without modifying their behavior

Ref: https://github.com/open-telemetry/opentelemetry-js/blob/c0468673cb0cfe61d12edf69745fabfdf940d7b0/api/src/experimental/trace/SugaredTracer.ts#L30-L44

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for the callout, I just assumed this would just keep the same interface -.- and it bums me out that it doesnt 😭

@github-actions github-actions bot added the stale label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants