profiles: hardening and self-ref fixes #5648
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rusty-snake I noticed the comment in ghostwriter.profile on #2877. If it's not too much trouble, can you take a look/review this from that perspective? |
rusty-snake
reviewed
Feb 8, 2023
rusty-snake
reviewed
Feb 8, 2023
The hardening (whitelisting profile) was tested to be working fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have 2 profiles that refer to
firejailin private-etc (ghostwriter and peek), and one (peek) additionally includes it private-bin. IMO there is never a legitimate reason for this. This PR removes firejail from both profiles.