Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: add counters for started smgr/getpage requests #9069

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

problame
Copy link
Contributor

@problame problame commented Sep 19, 2024

After this PR

curl localhost:9898/metrics | grep smgr_ | grep start
pageserver_smgr_query_started_count{shard_id="0000",smgr_query_type="get_page_at_lsn",tenant_id="...",timeline_id="..."} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_db_size"} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_page_at_lsn"} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_rel_exists"} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_rel_size"} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_slru_segment"} 0

We instantiate the per-tenant counter only for get_page_at_lsn.

After this PR

```
curl localhost:9898/metrics | grep smgr_ | grep start
```

```
pageserver_smgr_query_started_count{shard_id="0000",smgr_query_type="get_page_at_lsn",tenant_id="...",timeline_id="..."} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_db_size"} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_page_at_lsn"} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_rel_exists"} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_rel_size"} 0
pageserver_smgr_query_started_global_count{smgr_query_type="get_slru_segment"} 0
```
@problame problame requested a review from a team as a code owner September 19, 2024 20:58
@problame problame requested a review from jcsp September 19, 2024 20:58
Copy link

4968 tests run: 4794 passed, 10 failed, 164 skipped (full report)


Failures on Postgres 17

Failures on Postgres 16

Failures on Postgres 15

Failures on Postgres 14

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_metrics_normal_work[release-pg14] or test_metrics_normal_work[release-pg14] or test_metrics_normal_work[release-pg15] or test_metrics_normal_work[release-pg15] or test_slots_and_branching[release-pg16] or test_metrics_normal_work[release-pg16] or test_metrics_normal_work[release-pg16] or test_metrics_normal_work[release-pg17] or test_metrics_normal_work[debug-pg17] or test_metrics_normal_work[release-pg17]"
Flaky tests (8)

Postgres 17

Postgres 16

Postgres 15

Postgres 14

Test coverage report is not available

The comment gets automatically updated with the latest test results
50268a7 at 2024-09-19T21:42:34.883Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant