Fix flakiness of test_timeline_copy. #9061
Open
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeline might be not initialized when timeline_start_lsn is queried. Spotted by CI.
koivunej
reviewed
Sep 19, 2024
Comment on lines
+170
to
+173
| assert s > Lsn(0) | ||
|
|
||
| wait_until(30, 1, timeline_start_lsn_non_zero) | ||
| return self.timeline_status(tenant_id, timeline_id).timeline_start_lsn |
There was a problem hiding this comment.
Suggested change
| assert s > Lsn(0) | |
| wait_until(30, 1, timeline_start_lsn_non_zero) | |
| return self.timeline_status(tenant_id, timeline_id).timeline_start_lsn | |
| assert s > Lsn(0) | |
| wait_until(30, 1, timeline_start_lsn_non_zero) | |
| return self.timeline_status(tenant_id, timeline_id).timeline_start_lsn |
Suggested change
| assert s > Lsn(0) | |
| wait_until(30, 1, timeline_start_lsn_non_zero) | |
| return self.timeline_status(tenant_id, timeline_id).timeline_start_lsn | |
| assert s > Lsn(0) | |
| return s | |
| return wait_until(30, 1, timeline_start_lsn_non_zero) |
4968 tests run: 4804 passed, 0 failed, 164 skipped (full report)Flaky tests (4)Postgres 17
Postgres 16
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
9f3a369 at 2024-09-19T15:05:36.571Z :recycle: |
koivunej
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeline might be not initialized when timeline_start_lsn is queried. Spotted by CI.