Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): LSN lease edge cases around restarts/migrations #9055

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

yliang412
Copy link
Contributor

@yliang412 yliang412 commented Sep 19, 2024

Part of #7497, closes #8817.

Problem

See #8817.

Summary of changes

compute_ctl

  • Renew lsn lease as soon as /configure updates pageserver_connstr, use state_changed Condvar for synchronization.

pageserver

  • Have separate init_lsn_lease and renew_lsn_lease API. Verify lsn against only on the initial http lease request.

neon_local

  • add and call timeline_init_lsn_lease mgmt_api at static endpoint start. The initial lsn lease http request is sent when we run cargo neon endpoint start <static endpoint>.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Sep 19, 2024

4968 tests run: 4803 passed, 1 failed, 164 skipped (full report)


Failures on Postgres 15

  • test_remote_storage_backup_and_restore[True-real_s3]: release-arm64
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_remote_storage_backup_and_restore[release-pg15-True-real_s3]"
Flaky tests (4)

Postgres 17

Postgres 16

Postgres 14

Test coverage report is not available

The comment gets automatically updated with the latest test results
e7f34ef at 2024-09-19T20:15:43.706Z :recycle:

@yliang412 yliang412 changed the title [WIP] compute_ctl: renew lsn lease as soon as /configure updates pageserver_connstr fix(pageserver): LSN lease edge cases around restarts/migrations Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pageserver: LSN lease edge cases around restarts/migrations
1 participant