12648 epic upgrade to a newer debian 12 ci #9036
Conversation
python on debian 12 requires --break-system-packages flag
| cache-from: type=registry,ref=cache.neon.build/build-tools:cache-${{ matrix.arch }} | ||
| cache-to: ${{ github.ref_name == 'main' && format('type=registry,ref=cache.neon.build/build-tools:cache-{0},mode=max', matrix.arch) || '' }} | ||
| tags: neondatabase/build-tools:${{ inputs.image-tag }}-${{ matrix.arch }} | ||
| file: docker/debian/${{ matrix.os }}/Dockerfile.build-tools |
There was a problem hiding this comment.
Instead of copying files, can we pass the base image (debian:bookworm-slim/debian:bullseye-slim) as an argument?
There was a problem hiding this comment.
that's possible, however there are some package changes for each base image for that we need to add conditional checks to install package based on code-name, for that reason I created copy.
There was a problem hiding this comment.
|
|
||
| merge-images: | ||
| needs: [ build-image ] | ||
| runs-on: ubuntu-22.04 | ||
| strategy: | ||
| matrix: | ||
| os: [ bullseye, bookworm ] |
There was a problem hiding this comment.
GitHub already has runner.os, using matrix.os is confusing
There was a problem hiding this comment.
runner and matrix both are different thing, we can use code-name which they call in Debian term or we can call it debians
There was a problem hiding this comment.
will update this with debian_version
| @@ -99,5 +103,5 @@ jobs: | |||
| - name: Create multi-arch image | |||
| run: | | |||
| docker buildx imagetools create -t neondatabase/build-tools:${IMAGE_TAG} \ | |||
There was a problem hiding this comment.
The resulting tag should also include the debian version
| neondatabase/build-tools:${IMAGE_TAG}-${{ matrix.os }}-x64 \ | ||
| neondatabase/build-tools:${IMAGE_TAG}-${{ matrix.os }}-arm64 |
There was a problem hiding this comment.
It seems arch and os are swapped here
There was a problem hiding this comment.
this one is confusing, should we have matrix for this CI stage as well?
rahulinux
force-pushed
the
12648-epic-upgrade-to-a-newer-debian-12-ci
branch
2 times, most recently
from
59411f8
to
33538f6
Compare
rahulinux
force-pushed
the
12648-epic-upgrade-to-a-newer-debian-12-ci
branch
from
33538f6
to
6e3b687
Compare
Problem
Summary of changes
Checklist before requesting a review
Checklist before merging