Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: refactor json parsing #9013

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Conversation

conradludgate
Copy link
Contributor

Problem

current json parsing is a little bit expensive with untagged enums and intermediate allocations

Summary of changes

write custom deserialize impls to avoid untagged enum cost, and try and remove some intermediate allocs.

I eventually want to move to using DeserializeSeed to use an arena and to remove the need of serde_json::Value during parsing entirely.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Sep 16, 2024

4968 tests run: 4804 passed, 0 failed, 164 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 16

Code coverage* (full report)

  • functions: 32.0% (7414 of 23193 functions)
  • lines: 49.6% (59563 of 120028 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
98393c4 at 2024-09-17T11:38:38.076Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant