Add read check in IO#getbyte #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a different approach. The value of |
This was referenced Sep 2, 2023
Merged
herwinw
force-pushed
the
io_getbyte_writeonly
branch
from
0ca0f05
to
ed83614
Compare
For now a test has been added to `test/natalie/`. As soon as the upstream PR will be merged, we can remove this one.
herwinw
force-pushed
the
io_getbyte_writeonly
branch
from
ed83614
to
78d120d
Compare
|
This one is good to go now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #1190 where we had to convert the exception in case of no write access. Two helper methods have been added to help with this check, I expect we'll be needing a lot more of them.
ruby/spec#1068 has been added as an upstream request to add this to the specs. For the time being, a local test has has been added.