Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sort): correct kind for score sort #1

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

mychalvlcek
Copy link
Owner

fixes elastic#561

apupier and others added 25 commits January 24, 2024 13:26
* WIP initial implementation, User crud, half Article crud

* WIP more article crud (update, complete fav/unfav) some refactor

* WIP various bugfixes, making responses compatible with API

* WIP finished articles + comments + tags crud. not bug checked though

* minimal bugfix, added waitFor and refresh to post and delete methods

* minor refactor, WIP documentation, added license

* major refactor, added validation to user controller, WIP testcontainer unit test example

* working testcontainer unit test

* the rest of the test

* style refactor, more documentation

* fully documented user service, linting

* code style

* code style, a e s t e t h i c s

* quick bug fixes

* putting java instant directly into db

* logic optimizations, hashing passwords

* fixed unit test

* more documentation

* finished documenting methods, added README.md, set up gradle correctly, minor refactors

* fixed readme, added license to all files

* fixed readme

* feed follow fix, shortened comment id
Adds a number of improvements and bugfixes to the JSON and utility classes:

JSON framework:

* A new `BufferingJsonpMapper` allows the creation of `JsonGenerator` that store JSON events in a buffer that can be replayed. This is useful to efficiently create synthetic JSON documents.
* An additional `JsonpMapper.deserialize` method variant accepts the current JSON event. Fixes elastic#741
* The Jackson implementation of `JsonpMapper` now enables the `ACCEPT_SINGLE_VALUE_AS_ARRAY` deserialization feature. This allows single values in a JSON stream to be considered as a single-value collection.

API & transport framework:

* `ElasticsearchException` now holds the low level http response, so that the application can inspect the details of the error.
* Endpoints now have a `call` methods, to make calling endpoints programmatically easier. This is for advanced use, as an application will normally use the `ElasticsearchClient` that hides endpoint objects.
* A `BinaryDataResponse` can now easily be created from a byte array.

Test framework:

* The `ElasticsearchTestServer` now tries to contact an Elasticsearch server running on `http://elastic:changeme@localhost:9200` before spawning a container.
* A `MockHttpClient` has been added that allows writing integration-like tests without requiring a running server. This is an alternative to using `com.sun.net.httpserver.HttpServer` when we want to test http response decoding but don't need to test the network layer.
Adds helpers for ES|QL.

The ES|QL result format is meant to be compact: it is composed of a metadata part giving field names and their types and a 2D array of values, which isn't easy to use in application code.

This PR provides adapters that convert the ES|QL JSON result format into higher level types that are easier to use. Two adapters are provided:
* An `ObjectsAdatper` that combines field names and values from the array to build a collection of objects using JSON to object mapping
* A `ResultSetAdpater` that provides an implementation of the well-known JDBC `ResultSet`. This is a cursor-based API where the application can inspect at runtime the type and names of the ES|QL results, and is therefore more suited for ad-hoc or dynamic queries where the result structure isn't known in advance.

Along with adapters, additional methods in `ElasticsearchEsqlClient` provide simple way to send queries using just a string and optional parameters when you don't need to specify additional request details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScoreSort sort by Doc field
5 participants