LIB\NET45\MsgPack.XML TYPO #339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a6558fa)
(cherry picked from commit 9bedf6c)
* Collection traits detection does not care about source interface type itself * Creating delegate in generated code emits wrong method reference due to above wrong traits.
Remove the references for DataContractAttribute and DataMemberAttribute and re-implement with reflection-based attribute retrieving.
|
Sorry for delayed response, and I am sorry for asking, please check followings:
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG REPORT
SOURCE FILE: MsgPack.Cli.0.6.8.nupkg
WINDOWS INSTALL PATH: C:\Program Files\PackageManagement\NuGet\Packages\MsgPack.Cli.0.6.8\lib\net45\MsgPack.XML
BUG COUNT: 1 of 870,899 bytes
CLASS: TYPO
SEVERITY: NONE
Line 1968 has a typo: 'othereise' should be 'otherwise'
1966
1967 <c>true</c> if the <paramref name="value"> is immutable collection;
1968 othereise, <c>false</c>.
1969
FIX:
Open file in PowerShell Administrator mode using install path.
Use Ctrl-G shortcut to get 'GoToLine Box'. Enter 1968. Correct 'e' to 'w'. Save the file.
Happy typos!