Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Windows bindings for required symbols only #14

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

djc
Copy link
Member

@djc djc commented Sep 3, 2024

This avoids pulling in all of windows-sys and windows (even if most parts are excluded via Cargo features). The windows crate contains 9+ MB of code, so IMO avoiding that makes sense for a low-level/small crate like this.

@djc djc marked this pull request as draft September 3, 2024 08:45
@djc djc force-pushed the bindgen branch 6 times, most recently from 99af81c to 2584091 Compare September 3, 2024 09:17
@djc djc marked this pull request as ready for review September 3, 2024 09:23
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.06%. Comparing base (fbf8d71) to head (2452ee2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   94.55%   93.06%   -1.49%     
==========================================
  Files           1        1              
  Lines         202      202              
==========================================
- Hits          191      188       -3     
- Misses         11       14       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djc djc changed the title Generate bindings for required symbols only Generate Windows bindings for required symbols only Sep 3, 2024
@larseggert
Copy link
Collaborator

Should we exclude the bindings file from coverage checking?

@djc
Copy link
Member Author

djc commented Sep 3, 2024

Should we exclude the bindings file from coverage checking?

Yes, that probably makes sense. How do you want to do this?

@larseggert
Copy link
Collaborator

Should we exclude the bindings file from coverage checking?

Yes, that probably makes sense. How do you want to do this?

Change .codecov.yml as part of the PR.

@larseggert larseggert merged commit 655a937 into mozilla:main Sep 4, 2024
16 checks passed
@larseggert
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants