Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPN-6580 change 'App Exclusions' to 'Excluded Apps' #9879

Merged
merged 4 commits into from
Sep 17, 2024
Merged

VPN-6580 change 'App Exclusions' to 'Excluded Apps' #9879

merged 4 commits into from
Sep 17, 2024

Conversation

mcleinman
Copy link
Collaborator

Description

A quick string change.

  • I also changed dev-only strings (test descriptions and some markdown docs) for consistency for future maintainers of the app.
  • I couldn't find a spot where we still use infoText2, so I removed that string.
  • The help info sheet for the feature already used the "excluded apps" nomenclature, so there was nothing to update there.

Reference

VPN-6580

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

strseb
strseb approved these changes Sep 16, 2024
View reviewed changes
docs/rfcs/0005-suggested-excluded-apps-tech-spec.md Outdated
@@ -154,7 +154,7 @@ The excluded apps list will likely live in the client repo. There are ways to we
Considerations for roll out
----------------------

While the reworked app exclusion page will affect all platforms that support split tunneling, notifications will only be shown to users who have already allowed our app to send them. On mobile, we show the "approve notifications" screen immediately upon launching the app for the first time, which likely depresses approval rates. We may want to re-consider how we show this as part of onboarding.
While the reworked exclulded apps page will affect all platforms that support split tunneling, notifications will only be shown to users who have already allowed our app to send them. On mobile, we show the "approve notifications" screen immediately upon launching the app for the first time, which likely depresses approval rates. We may want to re-consider how we show this as part of onboarding.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

docs/rfcs/0005-suggested-excluded-apps-tech-spec.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmmm... i thought the point of these that they are historic docs (once accepted) not docs we need to keep up to date for ever 😅 Appreciate it tho :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, wasn't sure that was strictly necessary (and I wouldn't ding someone else's review for not including it), but it came up in a global search for the term so I figured it would help it be clearer for the future. (Though had I changed logic relating to that doc, I wouldn't have updated the doc. 🤷🏻 )

flodolo
flodolo requested changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@flodolo flodolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me or we keep going back and forth on the terminology for this feature? Was the impact on SuMO accounted for here?

We still have strings in Pontoon referencing Excluded apps from the previous round.

src/translations/strings.yaml
infoLinkText: Learn more
infoCardDescription:
value: VPN must be off to edit App exclusions
comment: Displays inside the information card at the top of the app exclusions screen when the VPN is on
value: VPN must be off to edit Excluded apps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To change an existing string you need a new ID.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote it that way initially. But do you think the translations for "App exclusions" and "Excluded apps" will be substantially different? If not, perhaps we don't need to bother the translators with this one. I'll defer to you.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, if we think a fix it's worth for English (for consistency), we also want it in other locales. The translations will be definitely different between the two.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I've updated the PR to use new string IDs.

src/translations/strings.yaml Outdated
@@ -323,7 +318,7 @@ systray:

settings:
privacySettings: Privacy features
appExclusionSettings: App exclusions
appExclusionSettings: Excluded apps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, needs a new ID.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per above, these now have new IDs.

@mcleinman
Copy link
Collaborator Author

Is it just me or we keep going back and forth on the terminology for this feature? Was the impact on SuMO accounted for here?

We still have strings in Pontoon referencing Excluded apps from the previous round.

I'll let Santiago speak to the terminology updates on this. I know some places (the widget?) already use Excluded apps, so this is standardizing the naming.

@albionx
Copy link
Collaborator

albionx commented Sep 17, 2024

@flodolo Yes, the SUMO changes are accounted for here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1916518
It will go live once this version is out.

@mcleinman mcleinman merged commit 6655e48 into main Sep 17, 2024
113 checks passed
@mcleinman mcleinman deleted the vpn-6580-update-to-excluded-apps branch September 17, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flodolo flodolo flodolo approved these changes

@strseb strseb strseb approved these changes

@oskirby oskirby Awaiting requested review from oskirby

@lesleyjanenorton lesleyjanenorton Awaiting requested review from lesleyjanenorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcleinman @albionx @flodolo @strseb