Allow *.{miraheze,wikitide}.org and the custom domain for TemplateStyles #5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, /w/img_auth.php URLs cannot be used for TemplateStyles, which is
problematic for private wikis (example: #general in Discord/#miraheze-offtopic
on IRC, at 2024-09-17 10:17:35 UTC).
We allow `[a-zA-Z0-9\-]\.(miraheze|wikitide)\.org/w/img_auth.php` for Miraheze
controlled domains, and `{$wi->server}/w/img_auth.php` for custom domains. In
the event that the wiki is not a custom domain, it will fallback to the
Miraheze domain and would effectively be a no-op.
Universal-Omega
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, /w/img_auth.php URLs cannot be used for TemplateStyles, which is problematic for private wikis (example: #general in Discord/#miraheze-offtopic on IRC, at 2024-09-17 10:17:35 UTC).
We allow
[a-zA-Z0-9\-]\.(miraheze|wikitide)\.org/w/img_auth.phpfor Miraheze controlled domains, and{$wi->server}/w/img_auth.phpfor custom domains. In the event that the wiki is not a custom domain, it will fallback to the Miraheze domain and would effectively be a no-op.