Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean more stale origins #3561

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

originalsouth
Copy link
Contributor

Changes

Clean up all non-inference type origins that have empty results in Octpoes/XTDB.

Issue link

N/A

Demo

N/A

QA notes

Verify that, in a steady state, there are no non-inference type origins that have empty results in Octpoes/XTDB. This can be done using xtdb-cli.py or visually VisualOctopoesStudio.

To use xtdb-cli.py the following query checks for empty results for non-inference origins:
octopoes/tools/xtdb-cli.py query '{:query {:find [(pull ?var [*])] :where [[?var :type "Origin"]]}}}' | jq -C '.[][] | select(.origin_type != "inference" and (.result | length == 0))'


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@originalsouth originalsouth requested a review from a team as a code owner September 19, 2024 08:02
@originalsouth originalsouth added octopoes Issues related to octopoes tech-debt labels Sep 19, 2024
@noamblitz
Copy link
Contributor

Will test with empty observations in a bit :)

@noamblitz
Copy link
Contributor

Jup works. Normalizers that yield empty observations after yielding observations with objects still nicely clean up their old data.

@noamblitz
Copy link
Contributor

image

After running ssl certificates on a website without a cert, the observation is nomo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
octopoes Issues related to octopoes tech-debt
Projects
Status: Ready for merge
Development

Successfully merging this pull request may close these issues.

3 participants