Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗️ Build and publish dev container to a registry #855

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions .devcontainer/data-engineering/devcontainer.json

This file was deleted.

21 changes: 21 additions & 0 deletions .devcontainer/devcontainer-build.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"name": "ministryofjustice-data-platform",
"image": "mcr.microsoft.com/devcontainers/base:ubuntu",
"features": {
"ghcr.io/devcontainers/features/common-utils:2": { "configureZshAsDefaultShell": true },
"ghcr.io/devcontainers/features/docker-in-docker:2": {},
"./features/src/base": {},
"./features/src/aws-tools": {},
"./features/src/cicd-tools": {},
"./features/src/container-tools": {},
"./features/src/git-tools": {},
"./features/src/kubernetes-tools": {},
"./features/src/policy-tools": {},
"./features/src/pulumi-tools": {},
"./features/src/terraform-tools": {}
},
"overrideFeatureInstallOrder": [
"ghcr.io/devcontainers/features/common-utils",
"./features/src/base"
]
}
12 changes: 12 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"name": "ministryofjustice-data-platform",
"image": "ghcr.io/ministryofjustice/data-platform-devcontainer:latest",
"remoteUser": "vscode",
"runArgs": ["--name=ministryofjustice-data-platform-devcontainer"],
"mounts": [
{ "source": "ministryofjustice-data-platform-devcontainer-persisted", "target": "/opt/vscode-dev-containers", "type": "volume" },
{ "source": "ministryofjustice-data-platform-devcontainer-workspace", "target": "/home/vscode/workspace", "type": "volume" },
{ "source": "ministryofjustice-data-platform-devcontainer-commandhistory", "target": "/home/vscode/.commandhistory", "type": "volume" }
],
"workspaceFolder": "/home/vscode/workspace"
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,10 @@
}
},
"mounts": [{ "source": "ministryofjustice-data-platform-devcontainer-gh", "target": "/home/vscode/.config/gh", "type": "volume" }],
"customizations": {
"vscode": {
"extensions": ["EditorConfig.EditorConfig", "GitHub.vscode-pull-request-github", "GitHub.vscode-github-actions"]
}
},
"installsAfter": ["./features/src/base"]
}
8 changes: 8 additions & 0 deletions .devcontainer/hack/build.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/usr/bin/env bash

devcontainer build \
--image-name "ghcr.io/ministryofjustice/data-platform-devcontainer:latest" \
--platform "linux/arm64" \
--push "false" \
--workspace-folder . \
--config .devcontainer/devcontainer-build.json
34 changes: 0 additions & 34 deletions .devcontainer/platform-engineering/devcontainer.json

This file was deleted.

89 changes: 87 additions & 2 deletions .github/workflows/devcontainer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ on: # yamllint disable-line rule:truthy
- .github/workflows/devcontainer.yml
- .github/workflows/path-filter/devcontainer.yml
- .devcontainer/**
push:
branches:
- main
paths:
- .github/workflows/devcontainer.yml
- .github/workflows/path-filter/devcontainer.yml
- .devcontainer/**

permissions: read-all

Expand All @@ -17,6 +24,7 @@ env:

jobs:
detect-changes:
if: github.ref != 'refs/heads/main'
name: Detect changes
runs-on: ubuntu-latest
outputs:
Expand All @@ -33,7 +41,7 @@ jobs:
filters: .github/workflows/path-filter/devcontainer.yml

test:
if: ${{ needs.detect-changes.outputs.features != '[]' }}
if: (github.ref == 'refs/heads/main') && (needs.detect-changes.outputs.features != '[]')
needs: [detect-changes]
name: Test
runs-on: ubuntu-latest
Expand Down Expand Up @@ -68,7 +76,7 @@ jobs:
--base-image devcontainer

test-scenarios:
if: ${{ needs.detect-changes.outputs.features != '[]' }}
if: (github.ref == 'refs/heads/main') && (needs.detect-changes.outputs.features != '[]')
needs: [detect-changes]
name: Test Scenarios
runs-on: ubuntu-latest
Expand Down Expand Up @@ -101,3 +109,80 @@ jobs:
--features ${{ matrix.feature }} \
--skip-autogenerated \
--base-image devcontainer

build:
if: github.ref != 'refs/heads/main'
name: Build
runs-on: ubuntu-latest
strategy:
matrix:
platform: [linux/amd64, linux/arm64]
steps:
- name: Checkout
id: checkout
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3

- name: Install devcontainer CLI
id: install_devcontainer_cli
run: npm install -g @devcontainers/cli@${{ env.DEVCONTAINER_CLI_VERSION }}

- name: Set up Docker QEMU
if: ${{ matrix.platform == 'linux/arm64' }}
id: setup_docker_qemu
uses: docker/setup-qemu-action@2b82ce82d56a2a04d2637cd93a637ae1b359c0a7 # v2.2.0

- name: Set up Docker Buildx
if: ${{ matrix.platform == 'linux/arm64' }}
id: setup_docker_buildx
uses: docker/setup-buildx-action@4c0219f9ac95b02789c1075625400b2acbff50b1 # v2.9.1

- name: Build Image
id: build_image
run: |
devcontainer build \
--platform ${{ matrix.platform }} \
--image-name ghcr.io/ministryofjustice/data-platform-devcontainer \
--workspace-folder . \
--config .devcontainer/devcontainer-build.json

publish:
# if: github.ref == 'refs/heads/main'
name: Publish
runs-on: ubuntu-latest
permissions:
id-token: write
packages: write
steps:
- name: Checkout
id: checkout
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3

- name: Install devcontainer CLI
id: install_devcontainer_cli
run: npm install -g @devcontainers/cli@${{ env.DEVCONTAINER_CLI_VERSION }}

- name: Set up Docker QEMU
id: setup_docker_qemu
uses: docker/setup-qemu-action@2b82ce82d56a2a04d2637cd93a637ae1b359c0a7 # v2.2.0

- name: Set up Docker Buildx
id: setup_docker_buildx
uses: docker/setup-buildx-action@4c0219f9ac95b02789c1075625400b2acbff50b1 # v2.9.1

- name: Login to GitHub Container Registry
id: ghcr_login
uses: docker/login-action@465a07811f14bebb1938fbed4728c6a1ff8901fc # v2.2.0
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Publish Image
id: publish_image
run: |
devcontainer build \
--image-name "ghcr.io/ministryofjustice/data-platform-devcontainer:latest" \
--push "true" \
--platform "linux/amd64,linux/arm64" \
--workspace-folder . \
--config .devcontainer/devcontainer-build.json