Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to relative path #523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

luckyraul
Copy link

fix for #496

@luckyraul
Copy link
Author

@d4be4st Can you have a look please?

@d4be4st
Copy link
Member

d4be4st commented Oct 6, 2017

I have added a comment on #496 (comment)

But this PR needs work.

@@ -36,6 +36,7 @@ build_path="./tmp/build-$(date +%s)$RANDOM"

version="<%= next_version %>"
release_path="<%= fetch(:releases_path) %>/$version"
release_relative_path="releases/$version"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either we do all relative or all absolute.

Or maybe add a configuration variable which would set only the current as relative

Now there are shared paths that are absolute...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants