-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports PHPUnit 11 #109
Supports PHPUnit 11 #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice additions, thank you 💪 🤗
Seems like there are some issues with the lock file, as soon the ci is green, i can merge and release it. |
572aa6a
to
b99aa9d
Compare
@michaelpetri Thank you for suggestion. I fixed and squashed it. |
I think we only need to drop support for php 8.1 and everything will be green 🤞 |
b99aa9d
to
7e20552
Compare
7e20552
to
41c0c4a
Compare
Dropping 8.1 makes sense since it is still possible to install past versions of phpunit-consecutive-arguments, but it is somewhat unfriendly for users. Here we can work around the laminas-continuous-integration-action constraint by removing I tested it here and it seems to work: zonuexe#1 |
I think this doesn't make that much sense since laminas action checks against lowest, locked and highest versions by design? I really don't see any problem to drop 8.1, it's totally okay to only support only the latest two major versions. Also keep in mind, this lib has not that much users and the current 0.2 version is only used by php 8.2 users. So let's just drop it before introducing some kind of CI hacks here! :) https://packagist.org/packages/michaelpetri/phpunit-consecutive-arguments/php-stats |
@michaelpetri You're right. I pushed the fix. |
@michaelpetri |
I think we can just exclude the local xsd from our config. I'm currently on a train with a weak to zero Internet connection, will check later or tomorrow. |
Thank you for your work. This is because the schema path is embedded in laminas-continuous-integration-action, so from |
A temporary workaround was provided by |
c23385d
to
bc226b2
Compare
I'm not a big fan of this workaround, but let's not block this any longer so you can keep working on your project :D I'm very sorry I didn't reply over the weekend, my phone decided to kill itself and I was busy with personal things. Thanks for all of your effort 💪 🤗 |
Thank you very much for your cooperation!
me too. These should be improved by fixes from upstream projects! |
First of all, thank you for providing this package!
This was very helpful for us migrating from PHPUnit 9 to 10.
And we are trying to update to PHPUnit 11 so we will submit a PR.